Several EMU e-DSP Control bug

Russ · Jul 30, 2009, 08:01 PM

I can see part of the problem, but I cannot trace everything since some of the code is still not available.

What I can see, is that iKXAddOnManager::init is called separately for per device addons and system wide addons. iKXAddOnManager::init initializes it's menu variable with the value MENU_ADDON_BASE which I do not see defined anywhere or updated anywhere (I do not even see it referenced anywhere else). Assuming that value is a constant, then it would explain what I am seeing (regarding per device addons vs system wide addons). I do not see where init() is done for different addon instances of per device addons, but I would guess it is using a similar code (i.e. maybe it calls iKXAddOnManager::init seperatly for each addtional instance?).

That is probably as much as I am going to be able to learn from looking at the code... I guess instead of initializing the menu variable (used by init()) to MENU_ADDON_BASE, the addonmgr class should have an internal variable (which can be initialized to MENU_ADDON_BASE) that is updated to the last menu base value when init()'s while loop completes, so that it can be used to initialize init()'s menu pointer when init() is called again (something like that).

@diabLe
I do not know if you installed 3548 x86 as of yet, but I compiled a version of the E-DSP addon for 3548 x86 with a workaround that should allow you to configure both cards, if you want to give it a try: (temp link removed)

---
The workaround just manually increments the menu_base.
i.e.
The only source code change is:

Code:

int iEDSPControlAddOn::init(int p)
{
    edsp_dialog=NULL;
    
    if(check_versions())
        return -1;
    
    dword is_edsp=0;
    
    ikx=kx_manager->get_ikx(p);
    
    if(ikx && ikx->get_dword(KX_DWORD_IS_EDSP,&is_edsp)==0 && is_edsp)
    {
/****************************/
        menu_base += p * 10;
/****************************/
        init_firmware();
        return 0;
    }
    else
        return -2;
}

I think that should work as a temporary workaround...

diabLe · Jul 31, 2009, 04:07 PM

hi ,

i've tried the 3548 , but i've reinstalled the 3545b because 3548 is not earlier compatible with PROFX and UFX , and i can't do that i want without. but i'll try to test your addon quickly

thx again

**Eugene Gavrilov** · Sep 17, 2009, 02:20 PM

Quote:

iKXAddOnManager::init initializes it's menu variable with the value MENU_ADDON_BASE which I do not see defined anywhere or updated anywhere

this is the exact reason for the problem. mnu_idx is initialized to MENU_ADDON_BASE on each kXAddOnManager::init() call, I will fix this in 3540

E.

Russ · Sep 18, 2009, 06:16 AM

I can confirm that the issue with the menu_base is fixed in 3550.

I repeated the test I did previously (3 system wide addons and 3 per device addons, on a system with 2 cards installed) and each addon/addon instance now has a unique menu_base.

i.e.
System_Wide_Addon_1: menu_base = 1100
System_Wide_Addon_2: menu_base = 1110
System_Wide_Addon_3: menu_base = 1120

Per_Device_Addon_1
- Instance 1 (1st card): menu_base = 1130
- Instance 2 (2nd card): menu_base = 1160
Per_Device_Addon_2
- Instance 1 (1st card): menu_base = 1140
- Instance 2 (2nd card): menu_base = 1170
Per_Device_Addon_3
- Instance 1 (1st card): menu_base = 1150
- Instance 2 (2nd card): menu_base = 1180

diabLe · Jan 2, 2010, 09:29 PM

HI All ,

i've finally tried the 3550 ( doesn't have many time since this summer

and that's works perfectly

great thx for your work and investment.

skl

Jul 30, 2009, 08:01 PM	#31
Russ HardwareHeaven Extreme Member Join Date: Jan 2005 Posts: 5,561 Rep Power: 62	Re: Several EMU e-DSP Control bug I can see part of the problem, but I cannot trace everything since some of the code is still not available. What I can see, is that iKXAddOnManager::init is called separately for per device addons and system wide addons. iKXAddOnManager::init initializes it's menu variable with the value MENU_ADDON_BASE which I do not see defined anywhere or updated anywhere (I do not even see it referenced anywhere else). Assuming that value is a constant, then it would explain what I am seeing (regarding per device addons vs system wide addons). I do not see where init() is done for different addon instances of per device addons, but I would guess it is using a similar code (i.e. maybe it calls iKXAddOnManager::init seperatly for each addtional instance?). That is probably as much as I am going to be able to learn from looking at the code... I guess instead of initializing the menu variable (used by init()) to MENU_ADDON_BASE, the addonmgr class should have an internal variable (which can be initialized to MENU_ADDON_BASE) that is updated to the last menu base value when init()'s while loop completes, so that it can be used to initialize init()'s menu pointer when init() is called again (something like that). @diabLe I do not know if you installed 3548 x86 as of yet, but I compiled a version of the E-DSP addon for 3548 x86 with a workaround that should allow you to configure both cards, if you want to give it a try: (temp link removed) --- The workaround just manually increments the menu_base. i.e. The only source code change is: Code: int iEDSPControlAddOn::init(int p) { edsp_dialog=NULL; if(check_versions()) return -1; dword is_edsp=0; ikx=kx_manager->get_ikx(p); if(ikx && ikx->get_dword(KX_DWORD_IS_EDSP,&is_edsp)==0 && is_edsp) { /***************************/ menu_base += p 10; /***************************/ init_firmware(); return 0; } else return -2; } I think that should work as a temporary workaround... Last edited by Russ; Nov 9, 2009 at 06:33 PM.*

Jul 31, 2009, 04:07 PM	Thread Starter #32
diabLe HardwareHeaven Junior Member Join Date: Nov 2006 Location: FRANCE, NANCY Posts: 36 Rep Power: 0	Re : Several EMU e-DSP Control bug hi , i've tried the 3548 , but i've reinstalled the 3545b because 3548 is not earlier compatible with PROFX and UFX , and i can't do that i want without. but i'll try to test your addon quickly thx again

Sep 18, 2009, 06:16 AM	#34
Russ HardwareHeaven Extreme Member Join Date: Jan 2005 Posts: 5,561 Rep Power: 62	Re: Several EMU e-DSP Control bug I can confirm that the issue with the menu_base is fixed in 3550. I repeated the test I did previously (3 system wide addons and 3 per device addons, on a system with 2 cards installed) and each addon/addon instance now has a unique menu_base. i.e. System_Wide_Addon_1: menu_base = 1100 System_Wide_Addon_2: menu_base = 1110 System_Wide_Addon_3: menu_base = 1120 Per_Device_Addon_1 - Instance 1 (1st card): menu_base = 1130 - Instance 2 (2nd card): menu_base = 1160 Per_Device_Addon_2 - Instance 1 (1st card): menu_base = 1140 - Instance 2 (2nd card): menu_base = 1170 Per_Device_Addon_3 - Instance 1 (1st card): menu_base = 1150 - Instance 2 (2nd card): menu_base = 1180

Jan 2, 2010, 09:29 PM	Thread Starter #35
diabLe HardwareHeaven Junior Member Join Date: Nov 2006 Location: FRANCE, NANCY Posts: 36 Rep Power: 0	Re : Several EMU e-DSP Control bug HI All , i've finally tried the 3550 ( doesn't have many time since this summer and that's works perfectly great thx for your work and investment. skl Last edited by diabLe; Jan 7, 2010 at 06:21 PM.